Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper script for running gpgbridge #11

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Helper script for running gpgbridge #11

merged 3 commits into from
Sep 18, 2020

Conversation

mhyllander
Copy link
Owner

Thank you to @tetov for the contribution of a helper script to run gpgbridge. I made some smaller modifications due to changes I made in gpgbridge, and updated the documentation.

@mhyllander mhyllander merged commit dbd875e into master Sep 18, 2020
@mhyllander mhyllander deleted the sh_helper branch September 18, 2020 10:11
@tetov
Copy link
Contributor

tetov commented Sep 18, 2020

Sorry, I've been a bit busy. But there's some errors in the setup I proposed. Something about needing to source the script, and you can't pass arguments when you source something. Have you tested this? My quickfix was to export arguments as variables and then source..

@mhyllander
Copy link
Owner Author

Well, same here. But actually your helper script works well. You just run it as an ordinary script, no sourcing needed. I tested it and made some minor adjustments, that's all.

@mhyllander
Copy link
Owner Author

@tetov Actually you were right, there was a problem. But it is that the start_gpgbridge function needs to export the SSH_AUTH_SOCK environment variable, and it can't do that from a sub-shell. So the script file needs to be sourced. I fixed it in #13 by moving the args parsing into the start_gpgbridge function instead, so you can call start_gpgbridge --wsl2 --ssh after sourcing the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants