Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode enable mechanism #1216

Closed
GCHQ-Developer-094 opened this issue Aug 13, 2024 · 5 comments
Closed

Dark mode enable mechanism #1216

GCHQ-Developer-094 opened this issue Aug 13, 2024 · 5 comments
Assignees
Milestone

Comments

@GCHQ-Developer-094
Copy link

GCHQ-Developer-094 commented Aug 13, 2024

Summary

In parallel with our dark mode offering, we want a means in order to both enable and disable (on and off) the implementation of said dark mode.

💬 Description

It is assumed the use of a switch or toggle component will be utilised to achieve this. However, research should be conducted and various options presented.

Outputs

  • Conduct desk research
  • Experiment with existing components but also don't be afraid to create something bespoke
  • Several options to present back to team
  • Think about how we will want to get feedback from the community before refining designs

💰 User value

Easy out of the box means for customers to apply to products, ensuring seamless experience for the end user.

Acceptance Criteria

Image

@GCHQ-Developer-465
Copy link
Contributor

GCHQ-Developer-465 commented Aug 15, 2024

As already spoken about, this ticket relates slightly with 1033 in the way the work could be done. However 1033 has a different use case. Majority of sites use a switch for Light mode / Dark mode. Therefore a switch component should be used for this. Research is being done already to investigate this.

@GCHQDeveloper618 GCHQDeveloper618 self-assigned this Aug 19, 2024
@GCHQ-Developer-299
Copy link
Contributor

Going to go back to design to clarify final designs and decide whether this work is just for top nav for now so we can implement on guidance site

@GCHQDeveloper618
Copy link

updated figma to show button placement on small screen

@MI6-255
Copy link
Contributor

MI6-255 commented Nov 21, 2024

Add this as a pattern to pattern pages. Include adding code examples to the dark mode page. Also add it to our top navigation and how to control the theme and storing the state. Include how the background will switch

@ad9242
Copy link
Contributor

ad9242 commented Nov 26, 2024

initial work done in #1222

still to do:

  • storing the setting
  • detecting os\browser settings for default
  • full dark mode of site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

7 participants