-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(root): adds dark mode switch #1222
Conversation
View your branch deployment here: https://mi6.github.io/ic-design-system-githubpages/branches/dark-mode-toggle |
dfa0765
to
ef0bfa8
Compare
Suggestion to use local storage or a cookie rather than session storage. If you open a page in a new window, it reverts back to your OS setting |
ef0bfa8
to
b431814
Compare
At 90% page zoom, when hovering the button, I get a horizontal scroll appear. Only when going to light mode though. Small issue but overflow-x: hidden on the fixes it if it is seen as an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple of issues. The first time I open the site with dark mode as my system setting, it seems to know I'm in dark mode but doesn't update the site:
Cookie banner
After I click the dark mode enabler button to light mode then dark mode again it's fixed itself and displays dark mode.
When in dark mode, the bottom image on the homepage means that some of the text isn't readable, a new image might need generating for dark mode that has darker boxes.
73709a8
to
351e8d8
Compare
a6ab0d7
to
82701cd
Compare
79c1175
to
82d5cc5
Compare
82d5cc5
to
067c8e7
Compare
adds dark mode switch to site
067c8e7
to
04094c4
Compare
… & dark colors to guidance site added dark mode colors to guidance site elements not already included, added theme preferences to sessionStorage so choice persists, and theme now defaults to the system preference
renamed classname to wrapper as it was passing down styles to light-dom components with the same classname
04094c4
to
4b83894
Compare
Summary of the changes
Related issue
#1216
Checklist