Fix touch offsets #422
Merged
Fix touch offsets #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miblanchard sorry to ping you in a comment, but I’m not able to request a review on this repo for some reason, but this fix really worked wonders for usability. I’m not sure how long this has been broken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that the slider's value is not accurate when tapping. The slider jumps to a lower value whenever dragging starts. It is even more incorrect when there is a custom
thumbTouchSizeis used, the problem is even worse.This happens on web, and also on mobile. Here is an example:
Before:
Screen.Recording.2024-03-03.at.10.00.11.PM.mov
This PR resolves the issue in my testing. Sliders are now much more accurate:
After:
Screen.Recording.2024-03-03.at.10.00.34.PM.mov
The one thing I'm not 100% happy with is that the dragging will still assume you want to drag the centre of the slider. We should ideally calculate the offset between the starting touch and that position, and maintain that as an offset, so that drags are relative. I may fix that in a follow-up PR if this gets merged.