Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dpi awareness support #10

Merged
merged 7 commits into from
Feb 16, 2022
Merged

Dpi awareness support #10

merged 7 commits into from
Feb 16, 2022

Conversation

FoxPride
Copy link
Contributor

@FoxPride FoxPride commented Dec 3, 2021

Fixes #6

@FoxPride
Copy link
Contributor Author

Also fixes #9

@FoxPride
Copy link
Contributor Author

Fix for #7

  • Removed Screen.FromWpfPoint because function was inconsistent since wpf coordinates can intersect between monitors.
  • Changed back Bounds from PixelBounds and added WpfBounds instead (old bounds since v1.1.0) to be compatible with version 1.0.0.
  • Added WpfWorking area.
  • Added description for WindowHelper.
  • Reworked SetWindowPosition function.

@FoxPride
Copy link
Contributor Author

@micdenny can please check this pr? Fixed some bugs and reworked to be more compatbile with version 1.0.0

@micdenny
Copy link
Owner

I would declare a breaking change here isn't it? v2.0.0?

@FoxPride
Copy link
Contributor Author

Yes, definitely version 2.0.0

@micdenny
Copy link
Owner

micdenny commented Feb 16, 2022 •
edited
Loading

@FoxPride I've fixed the PR, was started from an unsquashed master, I've hard resetted the branch on the origin (micdenny) master, then cherry picked all your item where you will remain author of it.

Now the conflicts are gone, and I'm ready to review it.

@micdenny
Copy link
Owner

@FoxPride Can you confirm that what I did is fine? do you see all your changes?

@FoxPride
Copy link
Contributor Author

@micdenny everything looks good

@micdenny micdenny merged commit c15b29e into micdenny:master Feb 16, 2022
This was referenced Feb 16, 2022
Closed
Closed
@FoxPride FoxPride deleted the dpi_awareness_support branch February 16, 2022 11:52
@micdenny
Copy link
Owner

micdenny commented Feb 16, 2022 •
edited
Loading

v2.0.0 has been released

@micdenny micdenny added this to the 2.0.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dpi fix breaks support on Windows 7
2 participants
@FoxPride @micdenny