Dpi awareness support #5

FoxPride · 2021-09-17T18:10:32Z

No description provided.

- All values returns in wpf units - Project update for StyleCop rules - Bugfix for SystemInformation.VirtualScreen returning only primary screen

…hould set WindowStyle="None" ResizeMode="NoResize" properties for window or you will get position problem. See dotnet/wpf#4127)

WindowHelper added; Some fixes for SystemInformation;

micdenny · 2021-09-17T20:00:43Z

Did you checked if the framework as the dpi awareness in the new sources? From winforms or wpf new sources? Because last time I did this library if I remember well I simply took the sources from winforms source code that were release publicly, now that is also open sourced and they did new netcore version maybe they did something about that we can copy as well?

FoxPride · 2021-09-17T20:15:21Z

Can't say about winforms but in WPF dpi awareness is working from NET Framework 4.6.0. I suppose winforms works too.
But the reason why I decided to use your library is that in Windows Forms Screen there is no way to get monitor dpi (you can only calculate dpi of primary). So in case I want to move window from one monitor to another (with different dpi scale) I will end up having wrong coordinates.

micdenny · 2021-09-21T08:43:00Z

@FoxPride what about create the DpiTest as net5 app?

micdenny

@FoxPride what about create the DpiTest as net5 app?

I'm doing it apart, moving under test folder with a name like WpfScreenHelper.DpiTestWpfApp

src/WpfScreenHelper/Screen.cs

FoxPride · 2021-09-21T11:14:09Z

@FoxPride what about create the DpiTest as net5 app?

I'm doing it apart, moving under test folder with a name like WpfScreenHelper.DpiTestWpfApp

.NET 5 should work too. I can bump version and rename project if you want to.

micdenny · 2021-09-21T11:33:04Z

I'm doing a cleanup and will push it

micdenny · 2021-09-21T13:16:41Z

I'm making some test and I can't reproduce the problem.

first of all why you have to set this in the manifest:

  <asmv3:application>
    <asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">
      <!-- Per Monitor V1 [OS >= Windows 8.1] 
         Values: False, True, Per-monitor, True/PM -->
      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true/PM</dpiAware>
      <!-- Per Monitor V1 [OS >= Windows 10 Anniversary Update (1607, 10.0.14393, Redstone 1)]
         Values: Unaware, System, PerMonitor -->
      <!-- Per Monitor V2 [OS >= Windows 10 Creators Update (1703, 10.0.15063, Redstone 2)]
         Value: PerMonitorV2 -->
      <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2, PerMonitor</dpiAwareness>
    </asmv3:windowsSettings>
  </asmv3:application>

when the default manifest template for a net5 wpf app says this:

Windows Presentation Foundation (WPF) applications are automatically DPI-aware and do not need to opt in.

  <!-- Indicates that the application is DPI-aware and will not be automatically scaled by Windows at higher
       DPIs. Windows Presentation Foundation (WPF) applications are automatically DPI-aware and do not need 
       to opt in. Windows Forms applications targeting .NET Framework 4.6 that opt into this setting, should 
       also set the 'EnableWindowsFormsHighDpiAutoResizing' setting to 'true' in their app.config. 
       
       Makes the application long-path aware. See https://docs.microsoft.com/windows/win32/fileio/maximum-file-path-limitation -->
  <!--
  <application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
      <longPathAware xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">true</longPathAware>
    </windowsSettings>
  </application>
  -->

BTW I run your sample app and when I move the window to a scaled monitor, it doesn't move correctly. I have 3 monitor, on one I've set a 150% scale, I'm doing it right?

It seems to work only when I align to top-right, right and bottom-right, if you have the window on unscaled monitor and you click to center on the scaled monitor, it will end up in the middle of the two monitors. If I drag the window on the scaled monitor I saw that it changes the size when half the window is on the scaled window, then the buttons you add works as expected.

If I add the actual published v1.0.0 package in fact is getting worst, because when the window is dragged on the scaled monitor, the buttons works badly, so the changes are of course doing something good 😉

But it works fine with v1.0.0 if I leave the manifest unchanged as dpi-aware should be already in every WPF app, and it works better (also works the center, left-right and right button from another monitor to a scaled one), why?

I'm for sure ignorant on this topic, so I'm trying to understand 😄

FoxPride · 2021-09-21T13:37:26Z

I'm making some test and I can't reproduce the problem.

first of all why you have to set this in the manifest:

  <asmv3:application>
    <asmv3:windowsSettings xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">
      <!-- Per Monitor V1 [OS >= Windows 8.1] 
         Values: False, True, Per-monitor, True/PM -->
      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true/PM</dpiAware>
      <!-- Per Monitor V1 [OS >= Windows 10 Anniversary Update (1607, 10.0.14393, Redstone 1)]
         Values: Unaware, System, PerMonitor -->
      <!-- Per Monitor V2 [OS >= Windows 10 Creators Update (1703, 10.0.15063, Redstone 2)]
         Value: PerMonitorV2 -->
      <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitorV2, PerMonitor</dpiAwareness>
    </asmv3:windowsSettings>
  </asmv3:application>

when the default manifest template for a net5 wpf app says this:

Windows Presentation Foundation (WPF) applications are automatically DPI-aware and do not need to opt in.

  <!-- Indicates that the application is DPI-aware and will not be automatically scaled by Windows at higher
       DPIs. Windows Presentation Foundation (WPF) applications are automatically DPI-aware and do not need 
       to opt in. Windows Forms applications targeting .NET Framework 4.6 that opt into this setting, should 
       also set the 'EnableWindowsFormsHighDpiAutoResizing' setting to 'true' in their app.config. 
       
       Makes the application long-path aware. See https://docs.microsoft.com/windows/win32/fileio/maximum-file-path-limitation -->
  <!--
  <application xmlns="urn:schemas-microsoft-com:asm.v3">
    <windowsSettings>
      <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
      <longPathAware xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">true</longPathAware>
    </windowsSettings>
  </application>
  -->

Looks like they changed smth for dpi scale in .NET 5 🤔. So it's better to stick to new manifest then.

BTW I run your sample app and when I move the window to a scaled monitor, it doesn't move correctly. I have 3 monitor, on one I've set a 150% scale, I'm doing it right?

I have the same configuration (150% and 100% monitors), works with 4.7.1 version. I'll test it for 5.0.0.

It seems to work only when I align to top-right, right and bottom-right, if you have the window on unscaled monitor and you click to center on the scaled monitor, it will end up in the middle of the two monitors. If I drag the window on the scaled monitor I saw that it changes the size when half the window is on the scaled window, then the buttons you add works as expected.

Oh I see. Looks like size of window ends up being bigger for second monitor and on first move can't detect dpi changed event. That's why it moves window to the center of two monitors.

If I add the actual published v1.0.0 package in fact is getting worst, because when the window is dragged on the scaled monitor, the buttons works badly, so the changes are of course doing something good 😉

But it works fine with v1.0.0 if I leave the manifest unchanged as dpi-aware should be already in every WPF app, and it works better (also works the center, left-right and right button from another monitor to a scaled one), why?

I'm for sure ignorant on this topic, so I'm trying to understand 😄

May be in .NET 5.0.0 we finally have right coordinates with scale calculation? If so that's a great news for future development (unfortunately not for older .NET Framework). I'll check it out!

micdenny · 2021-09-21T13:59:54Z

in the meanwhile I did some code review and pushed on your branch, take a look at it

micdenny · 2021-09-21T17:18:50Z

@FoxPride should we bump the version to a non-breaking change or to a breaking change one? 1.1.0 or 2.0.0?

FoxPride · 2021-09-21T17:24:50Z

🤔I designed changes to be compatible with previous version. So it can be just 1.1.0 update as for me.

FoxPride · 2021-09-21T17:26:35Z

in the meanwhile I did some code review and pushed on your branch, take a look at it

Thank you! I will have a look.

FoxPride · 2021-09-23T12:57:43Z

@micdenny Finally tested .NET 5.0 project on several setups and it works just fine! Small note: on windows 10 commenting manifest section about dpi awareness changes nothing so it can be used for windows 7\8 setup.

micdenny · 2021-09-23T16:57:32Z

published on nuget https://www.nuget.org/packages/WpfScreenHelper/1.1.0

andbayd added 4 commits May 23, 2021 06:39

Rework library for supporting dpi awareness:

e5bdc25

- All values returns in wpf units - Project update for StyleCop rules - Bugfix for SystemInformation.VirtualScreen returning only primary screen

Added test project for window position check (keep in mind that you s…

3ec229f

…hould set WindowStyle="None" ResizeMode="NoResize" properties for window or you will get position problem. See dotnet/wpf#4127)

Fix for MONITORINFOEX initialization after code cleanup

846f536

Final changes

4b976ff

WindowHelper added; Some fixes for SystemInformation;

micdenny reviewed Sep 21, 2021

View reviewed changes

src/WpfScreenHelper/Screen.cs Outdated Show resolved Hide resolved

code review

3b286e5

micdenny added 2 commits September 21, 2021 19:15

simplify build batch using dotnet tool

bc03c8c

upgrade to netcoreapp3.1 because netcoreapp3.0 is out of support

f59a7b5

bump version to v1.1.0

7f7b14c

micdenny approved these changes Sep 22, 2021

View reviewed changes

micdenny merged commit 6714ca8 into micdenny:master Sep 23, 2021

FoxPride deleted the dpi_awareness_support branch September 23, 2021 16:50

This was referenced Nov 23, 2021

Move window with diffrent dpi monitor #7

Closed

Dpi fix breaks support on Windows 7 #6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dpi awareness support #5

Dpi awareness support #5

FoxPride commented Sep 17, 2021

micdenny commented Sep 17, 2021

FoxPride commented Sep 17, 2021

micdenny commented Sep 21, 2021

micdenny left a comment

FoxPride commented Sep 21, 2021

micdenny commented Sep 21, 2021

micdenny commented Sep 21, 2021

FoxPride commented Sep 21, 2021

micdenny commented Sep 21, 2021

micdenny commented Sep 21, 2021

FoxPride commented Sep 21, 2021

FoxPride commented Sep 21, 2021

FoxPride commented Sep 23, 2021

micdenny commented Sep 23, 2021

Dpi awareness support #5

Dpi awareness support #5

Conversation

FoxPride commented Sep 17, 2021

micdenny commented Sep 17, 2021

FoxPride commented Sep 17, 2021

micdenny commented Sep 21, 2021

micdenny left a comment

Choose a reason for hiding this comment

FoxPride commented Sep 21, 2021

micdenny commented Sep 21, 2021

micdenny commented Sep 21, 2021

FoxPride commented Sep 21, 2021

micdenny commented Sep 21, 2021

micdenny commented Sep 21, 2021

FoxPride commented Sep 21, 2021

FoxPride commented Sep 21, 2021

FoxPride commented Sep 23, 2021

micdenny commented Sep 23, 2021