Skip to content

Commit

Permalink
opt: update GenerateLookupJoinsWithVirtualCols comment
Browse files Browse the repository at this point in the history
Epic: None

Release note: None
  • Loading branch information
mgartner committed Dec 5, 2022
1 parent 8a5cb51 commit 7e4b668
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions pkg/sql/opt/xform/join_funcs.go
Original file line number Diff line number Diff line change
Expand Up @@ -284,15 +284,9 @@ func (c *CustomFuncs) GenerateLookupJoins(
// |
// Scan(t)
//
// This function and its associated rule currently require that:
//
// 1. The join is an inner join.
// 2. The right side projects only virtual computed columns.
// 3. All the projected virtual columns are covered by a single index.
//
// It should be possible to support semi- and anti- joins. Left joins may be
// possible with additional complexity.
// TODO(mgartner): update this comment.
// This function and its associated rule currently require that the right side
// projects only virtual computed columns and all those columns are covered by a
// single index.
//
// It should also be possible to support cases where all the virtual columns are
// not covered by a single index by wrapping the lookup join in a Project that
Expand Down

0 comments on commit 7e4b668

Please sign in to comment.