Skip to content

Commit

Permalink
roachtest: move flaky test to activerecord ignore list
Browse files Browse the repository at this point in the history
This patch moves a flaky test from the blocklist to the ignore list
for the activerecord roachtest.

Release note: None
  • Loading branch information
andyyang890 committed Dec 5, 2022
1 parent 591995a commit 8f20899
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/cmd/roachtest/tests/activerecord_blocklist.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,7 @@ var activeRecordBlocklist = blocklist{
"PostgresqlRangeTest#test_timezone_array_awareness_tsrange": "27791",
"PostgresqlRangeTest#test_timezone_array_awareness_tzrange": "27791",
// TODO(yang): investigate cause further
"PostgreSQLReferentialIntegrityTest#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas": "unknown",
"PostgresqlTimestampWithAwareTypesTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_time_zone_set": "expected ActiveSupport::TimeWithZone, not Time",
"PostgresqlTimestampWithTimeZoneTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_timestamptz_and_time_zone_set": "expected ActiveSupport::TimeWithZone, not Time",
"PostgreSQLReferentialIntegrityTest#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas": "unknown",
}

var activeRecordIgnoreList = blocklist{
Expand Down Expand Up @@ -73,6 +71,8 @@ var activeRecordIgnoreList = blocklist{
"LengthValidationTest#test_validates_size_of_association_using_within": "flaky - sometimes complains that a relation does not exist",
"PostgresqlInfinityTest#test_where_clause_with_infinite_range_on_a_datetime_column": "flaky - sometimes complains that a relation does not exist",
"PostgresqlIntervalTest#test_interval_type": "flaky",
"PostgresqlTimestampWithAwareTypesTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_time_zone_set": "flaky - sometimes complains given Time instead of ActiveSupport::TimeWithZone",
"PostgresqlTimestampWithTimeZoneTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_timestamptz_and_time_zone_set": "flaky - sometimes complains given Time instead of ActiveSupport::TimeWithZone",
"RelationTest#test_finding_last_with_arel_order": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_joins_with_select_custom_attribute": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_order_triggers_eager_loading_when_ordering_using_hash_syntax": "flaky - sometimes complains that a relation does not exist",
Expand Down

0 comments on commit 8f20899

Please sign in to comment.