New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate classes better #18

Closed

michaelaye opened this issue Feb 16, 2022 · 0 comments

Labels

Owner

michaelaye commented Feb 16, 2022

RGB_NOMAP had code that should be a base class
SOURCE_PRODUCT has some similarities to BASE_PRODUCT but not close enough to be derived
SOURCE_PRODUCT gets its own local_path/remote_path/url/download code segment
- other products can inherit from SOURCE_PRODUCT and initialize it with the correct PRODUCT_ID string.

michaelaye added the enhancement label

michaelaye closed this as completed in

2b2b917

michaelaye added a commit that referenced this issue


          fixes #18

1904d40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment