Hotfix/unittests #67
Open
Hotfix/unittests #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 30, 2015 23:04
|
@michaeldfallen No interest in this one? ;) |
|
Only no time to check that it works on OSX and Ubuntu (my current platforms of choice). Wish I could automate the testing of these PRs but the test suite |
|
Will get to it, promise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix issue #38. As it turns out, some built in commands behave differently on Mac OS X and Linux.
In order to run the tests on Linux, I have added switch statements at some points to call the functions with the respective syntax.
Also I realized, that the tests only worked for me when I set the following options:
But that's probably just because these should be the defaults. I normally have them set to something else...