Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the unit tests in
libs/infinity_emb/tests/unit_test/test_engine.py
to improve test coverage and simplify the code. The most important changes include modifying parameterized tests to focus on thetorch
engine, refactoring the reranking logic, and consolidating assertions for differenttop_n
values.Improvements to test coverage and simplification:
libs/infinity_emb/tests/unit_test/test_engine.py
: Modifiedtest_async_api_torch
to only test thetorch
engine.libs/infinity_emb/tests/unit_test/test_engine.py
: Updatedtest_engine_reranker_torch_opt
to always useInferenceEngine.torch
and refactored the reranking logic to simplify the sorting and assertion steps. [1] [2]libs/infinity_emb/tests/unit_test/test_engine.py
: Modifiedtest_engine_reranker_top_n
to only test thetorch
engine and consolidated assertions for differenttop_n
values into a loop for better readability and maintainability. [1] [2]