Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix topk tests #406

Merged
merged 3 commits into from
Oct 8, 2024
Merged

fix topk tests #406

merged 3 commits into from
Oct 8, 2024

Conversation

michaelfeil
Copy link
Owner

This pull request includes several changes to the unit tests in libs/infinity_emb/tests/unit_test/test_engine.py to improve test coverage and simplify the code. The most important changes include modifying parameterized tests to focus on the torch engine, refactoring the reranking logic, and consolidating assertions for different top_n values.

Improvements to test coverage and simplification:

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (2351e26) to head (46da9c9).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   79.00%   78.73%   -0.27%     
==========================================
  Files          39       39              
  Lines        3015     3015              
==========================================
- Hits         2382     2374       -8     
- Misses        633      641       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 9ab1059 into main Oct 8, 2024
36 checks passed
@michaelfeil michaelfeil deleted the fix-topk-tests branch October 8, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants