spl-token: Add token_program_id parameter to associated token endpoints #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate_associated_token_account
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 88.95% 88.88% -0.07%
==========================================
Files 28 28
Lines 2282 2286 +4
==========================================
+ Hits 2030 2032 +2
- Misses 252 254 +2 |
michaelhly
changed the title
|
This change wasn't added to create_associated_token_account_idempotent |
|
Hey @anonymous-sushi thanks for bringing it up. I'll take a loook and raise an MR accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new paremeter
token_program_idtoget_associated_token_address&create_associated_token_account.This new paremeter should be one of
spl.token.constants.TOKEN_PROGRAM_IDorspl.token.constants.TOKEN_2022_PROGRAM_ID. Raises aValueErrorotherwise.It defaults to
TOKEN_PROGRAM_ID.Fixes #439