Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RPC health check instead of /health for is_connected #460

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Use RPC health check instead of /health for is_connected #460

merged 1 commit into from
Nov 10, 2024

Conversation

mp-freatic
Copy link
Contributor

Fixing #119

@mp-freatic mp-freatic marked this pull request as draft November 6, 2024 17:27
@mp-freatic mp-freatic marked this pull request as ready for review November 6, 2024 17:37
@mp-freatic
Copy link
Contributor Author

mp-freatic commented Nov 6, 2024 •
edited
Loading

Hey @michaelhly , just ran the local validator node and was able to run these :
image

But I'm not sure how these tests relate to my changes. Is that expected? 🤔

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.16%. Comparing base (890cbbb) to head (3a00466).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
+ Coverage   88.88%   89.16%   +0.27%     
==========================================
  Files          28       28              
  Lines        2286     2271      -15     
==========================================
- Hits         2032     2025       -7     
+ Misses        254      246       -8

michaelhly
michaelhly approved these changes Nov 10, 2024
View reviewed changes
Copy link
Owner

@michaelhly michaelhly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelhly michaelhly changed the title Fixed get_health call Use RPC health check instead of /health for is_connected Nov 10, 2024
@michaelhly michaelhly self-requested a review November 10, 2024 16:11
@michaelhly michaelhly changed the title Use RPC health check instead of /health for is_connected Use RPC health check instead of /health for is_connected Nov 10, 2024
@michaelhly michaelhly merged commit d1ae42f into michaelhly:master Nov 10, 2024
13 checks passed
@mp-freatic mp-freatic deleted the fix/get-health branch November 11, 2024 17:53
@mp-freatic
Copy link
Contributor Author

🎉 Awesome 🤗

@mp-freatic mp-freatic mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelhly michaelhly Awaiting requested review from michaelhly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mp-freatic @michaelhly