Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] Sync cassandra-env.sh and jvm.options with Cassandra 3 #328

Merged
merged 1 commit into from
Jan 11, 2017
Merged

[breaking] Sync cassandra-env.sh and jvm.options with Cassandra 3 #328

merged 1 commit into from
Jan 11, 2017

Conversation

wdauchy
Copy link
Contributor

@wdauchy wdauchy commented Jan 3, 2017

tested on both cassandra 2.1.x and 3.x

@michaelklishin
Copy link
Owner

Noted. Since the title says it includes breaking changes (and yes, some defaults indeed change), let's wait for 4.3.0 before merging this.

@michaelklishin michaelklishin self-assigned this Jan 3, 2017
@wdauchy wdauchy force-pushed the sync_conf branch 5 times, most recently from c40505d to d8e3d34 Compare January 3, 2017 16:08
@michaelklishin
Copy link
Owner

@wdauchy @jfwm2 speaking of 4.3.0, I can release it as soon as you folks confirm that master is in good enough shape for you to run it in production ;)

@wdauchy
Copy link
Contributor Author

wdauchy commented Jan 3, 2017

@michaelklishin this commit is in production on our side for a few months now (september). so in my opinion it is ok.

I however could not find a solution to fix tests; might need new eyes... any hint?

@michaelklishin
Copy link
Owner

@wdauchy I understand that but there is no shortage of other changes in master. They may or may not be in your deployed fork: I cannot know that and thus clarifying.

@michaelklishin
Copy link
Owner

I will take a look at the tests. chef-spec doesn't produce diffs so it has to be done by hand :(

@wdauchy
Copy link
Contributor Author

wdauchy commented Jan 3, 2017

@michaelklishin yup hard to cover all possible configurations; a merge several times before an official release will probably facilitate tests for people

@wdauchy wdauchy force-pushed the sync_conf branch 2 times, most recently from 6b1bed1 to 56338b0 Compare January 3, 2017 18:09
@wdauchy
[breaking] sync cassandra-env.sh and jvm.options with cassandra3
2f5b239 
tested on cassandra 2.1.x and 3.x

Signed-off-by: William Dauchy <w.dauchy@criteo.com>
Signed-off-by: Corentin Chary <c.chary@criteo.com>
@wdauchy
Copy link
Contributor Author

wdauchy commented Jan 4, 2017

@michaelklishin we are now good on tests side

@michaelklishin
Copy link
Owner

@wdauchy ack. I will proceed with the 4.3.0 release then.

@michaelklishin
Copy link
Owner

4.3.0 is out, let's wait for a few days and unless there's urgent need to do a point release, merge this.

@wdauchy
Copy link
Contributor Author

wdauchy commented Jan 10, 2017

agreed 👍

@michaelklishin michaelklishin merged commit c4b2439 into michaelklishin:master Jan 11, 2017
@michaelklishin
Copy link
Owner

Thank you!

michaelklishin added a commit that referenced this pull request Jan 11, 2017
@michaelklishin
Add #328 to ChangeLog.md
ec49380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdauchy @michaelklishin