Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a restart on-failure condition in systemd service unit #342

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

vdemonchy
Copy link
Contributor

No description provided.

@michaelklishin
Copy link
Owner

I guess this is a good default but there are cases where Cassandra intentionally shuts down (e.g. when it detects disk operation failures and assumes the disk is dysfunctional). So I expect this to become configurable one day.

@michaelklishin michaelklishin merged commit 96fa945 into michaelklishin:master Mar 6, 2017
@vdemonchy
Copy link
Contributor Author

Hello and thanks for the quick merge! You make a point indeed, I guess intentional shutdown for failure cases should result in a unclean exit code and but a clean signal, so on-abnormal would probably be a good fit if so.

@michaelklishin
Copy link
Owner

@vdemonchy agreed. Ideally we should configure the value via a node attribute.

@vdemonchy
Copy link
Contributor Author

Ok, so I'll test that and come back with another PR

@michaelklishin
Copy link
Owner

@vdemonchy thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants