Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation incorrect for http://reference.clojurerabbitmq.info/langohr.basic.html#var-publish #79

Closed
shmish111 opened this issue Feb 4, 2016 · 3 comments
Closed

documentation incorrect for http://reference.clojurerabbitmq.info/langohr.basic.html#var-publish #79

shmish111 opened this issue Feb 4, 2016 · 3 comments
Assignees
@michaelklishin

Comments

@shmish111
Copy link

publish does not use varagrs for properties however example in docs show that it does.
@michaelklishin
Copy link
Owner

@shmish111 I don't see any examples in master, possibly we haven't redeployed API reference docs in a while.

@shmish111
Copy link
Author

Also just found another one. Docs for publish says "Payload can be anything the langohr.conversion/BytePayload protocol is extended for" however the protocol is actually clojurewerkz.support.bytes/ByteSource

@michaelklishin michaelklishin self-assigned this Feb 5, 2016
michaelklishin added a commit that referenced this issue Feb 5, 2016
@michaelklishin
Correct code example, references #79
7fbc9f3
michaelklishin added a commit that referenced this issue Feb 5, 2016
@michaelklishin
Remove the :immediate flag
37fb005 
It hasn't been supported by RabbitMQ since 3.0.

References #79.
@michaelklishin
Copy link
Owner

@shmish111 OK, should be good now, thanks for bringing this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelklishin michaelklishin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelklishin @shmish111