Merge pull request #284 from vitorquintanilha/fix-channel-detail-as-e…

…mpty-array

Fixes issue when serializing ChannelDetails as an empty array

queues.go

@@ -68,6 +68,17 @@ type ChannelDetails struct {
 	User           string `json:"user"`
 }
 
+// Handles special case where `ChannelDetails` is an empty array
+// See https://github.com/rabbitmq/rabbitmq-server/issues/2684
+func (c *ChannelDetails) UnmarshalJSON(data []byte) error {
+	if string(data) == "[]" {
+		*c = ChannelDetails{}
+		return nil
+	}
+	type Alias ChannelDetails
+	return json.Unmarshal(data, (*Alias)(c))
+}
+
 // QueueDetail describe queue information with a consumer
 type QueueDetail struct {
 	Name  string `json:"name"`

unit_test.go

@@ -1,6 +1,8 @@
 package rabbithole
 
 import (
+	"encoding/json"
+
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
@@ -74,4 +76,20 @@ var _ = Describe("Unit tests", func() {
 			Ω(d).Should(Equal(Port(0)))
 		})
 	})
+	Context("ConsumerDetails marshalling", func() {
+		It("unmarshal ConsumerDetails when channel_details is an empty array", func() {
+			var d ConsumerDetail
+			s := []byte("{\"channel_details\":[]}")
+			err := json.Unmarshal(s, &d)
+			Ω(err).ShouldNot(HaveOccurred())
+			Ω(d.ChannelDetails).Should(Equal(ChannelDetails{}))
+		})
+		It("unmarshal ConsumerDetails when channel_details is an object", func() {
+			var d ConsumerDetail
+			s := []byte("{\"channel_details\":{\"name\":\"foo\"}}")
+			err := json.Unmarshal(s, &d)
+			Ω(err).ShouldNot(HaveOccurred())
+			Ω(d.ChannelDetails).Should(Equal(ChannelDetails{Name: "foo"}))
+		})
+	})
 })