Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shovel API: src-delete-after takes multiple types #149

Closed
justinbaur opened this issue Mar 9, 2020 · 1 comment · Fixed by #164
Closed

Shovel API: src-delete-after takes multiple types #149

justinbaur opened this issue Mar 9, 2020 · 1 comment · Fixed by #164
Milestone
2.5.0

Comments

@justinbaur
Copy link

justinbaur commented Mar 9, 2020 •
edited
Loading

Just logging something I've ran up against and may be able to contribute to at some point.

Based on the latest RabbitMQ documentation the src-delete-after attribute requires the json type to be an integer if setting temporary shovel length to an integer length.

Only supported options for rabbit-hole are "never" and "queue-length" as the json payload only supports sending a string.

rabbit-hole/shovels.go

Line 35 in a4ba81f

DeleteAfter string `json:"delete-after"`

@michaelklishin
Copy link
Owner

A PR that lifts this limitation would be welcome.

@mkuratczyk mkuratczyk mentioned this issue Sep 23, 2020
Merged
@michaelklishin michaelklishin added this to the 2.5.0 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

Add support for numeric delete-after values
2 participants
@michaelklishin @justinbaur