Add support for numeric delete-after values #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delte-after can be a string (eg. "never") or an integer. RabbitMQ does
not accept string-formatted integers ("42") so this PR changes the type
of the `DeleteAfter` field and adds a custom marshaler/unmarshaler
to handle both cases. As you can see in the tests, this may be a
breaking change - since values of different types cannot be equal in Go,
when comparing `DeleteAfter` with a string, you now need to convert one of the
values. However, most operations should work without code changes.
Fixes #149
michaelklishin
approved these changes
Sep 24, 2020
|
Thank you. Happy to do a minor version bump for this. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete-after can be a string (eg. "never") or an integer. RabbitMQ does
not accept string-formatted integers ("42") so this PR changes the type
of the
DeleteAfterfield and adds a custom marshaler/unmarshalerto handle both cases. As you can see in the tests, this may be a
breaking change - since values of different types cannot be equal in Go,
when comparing
DeleteAfterwith a string, you now need to convert one of thevalues. However, most operations should work without code changes.
Fixes #149