Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Client HTTP timeout #102

Merged
merged 1 commit into from
Jul 9, 2017
Merged

add Client HTTP timeout #102

merged 1 commit into from
Jul 9, 2017

Conversation

pierrre
Copy link
Contributor

@pierrre pierrre commented Jul 9, 2017 •
edited
Loading

add Client HTTP timeout

+ simplify the code

@pierrre
add Client HTTP timeout
a21f5a6 
+ simplify the code
@pierrre
Copy link
Contributor Author

pierrre commented Jul 9, 2017

Reason for this PR: sometimes the RabbitMQ HTTP API hangs indefinitely in my tests (on Travis).
I don't understand exactly why.

Anyway, I think it's great to allow the user to set a timeout on HTTP request.
It would be better to add context support, but it would require large changes in the code.

@michaelklishin
Copy link
Owner

I completely agree, having timeouts is a very good idea. Thank you.

@michaelklishin michaelklishin merged commit cbe44ff into michaelklishin:master Jul 9, 2017
@michaelklishin
Copy link
Owner

context support would be welcomed. Version will have to be bumped to 2.0 but I'm completely open to supporting two release series.

@pierrre
Copy link
Contributor Author

pierrre commented Jul 9, 2017

thank you !

@pierrre pierrre deleted the feature/client-timeout branch July 9, 2017 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierrre @michaelklishin