Add support to manipulate cluster name #104
Conversation
| @@ -265,6 +265,20 @@ var _ = Describe("Rabbithole", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Context("PUT /cluster-name", func() { | |||
| It("Set cluster name", func() { | |||
There was a problem hiding this comment.
This test does not restore cluster name to its original value.
There was a problem hiding this comment.
Ok, no problem. BTW, since cluster name is defined at run time and is hostname based, it may be more elegant and predictable to set arbitrarily a value in ./bin/ci/before_build.sh. Are you ok with that ?
There was a problem hiding this comment.
Yup. I don't think we depend on cluster name anywhere. rabbit@localhost is the value I'd use.
| // => ClusterName, err | ||
|
|
||
| // Rename cluster | ||
| resp, err := rmqc.SetClusterName(ClusterName{Name: "rabbitmq@rabbit-hole"}) |
There was a problem hiding this comment.
I wonder if this should take a string… or reusing the same struct is actually OK. In most cases I've seen a cluster name is not set to a previously fetched value.
There was a problem hiding this comment.
I initially chose to use a string as parameter, but I though passing a struct is more consistent with the API, since cluster name is set via the request body and not as part of path. I've have no problem to switch back to string.
There was a problem hiding this comment.
@gerhard and I discussed this and perhaps using a struct is not too odd. It would be more flexible should this part of the API change or require validation and it's not too weird for Go libraries to do something like this.
So no need for changing it. Thank you for responding so quickly!
GetClusterName() to fetch cluster name SetClusterName() to rename the cluster
|
I fixed the tests and updated doc.go |
|
Thank you! |
Hi,
thank you for this great package, it's very useful for my project. Since it requires to programmaticaly rename the cluster, I added SetClusterName()/GetClusterName() functions.
Thanks.
regards,