Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check RuntimeParameter value before creating FederationUpstream. #153

Merged
merged 2 commits into from
May 13, 2020
Merged

Check RuntimeParameter value before creating FederationUpstream. #153

merged 2 commits into from
May 13, 2020

Conversation

niclic
Copy link
Contributor

@niclic niclic commented May 12, 2020

This is a very minor follow-up to #150.

What does this PR do?

  • Eliminates possibility (unlikely) of panic in paramToUpstream when parameter map is nil.
  • Uses consistent format when initializing RuntimeParameter structs.

Thanks for all your help with these recent pull requests. I look forward to a new release soon.

@michaelklishin michaelklishin merged commit 9f8e3d8 into michaelklishin:master May 13, 2020
@michaelklishin
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niclic @michaelklishin