Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deprecated features endpoint #324

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

Zerpet
Copy link
Contributor

@Zerpet Zerpet commented Oct 30, 2024

Summary

  • Add support for deprecated features endpoint
  • Make tests more resilient to slow emit stats

Bump in Go version for dev container, and bump RabbitMQ in docker
command.
Without the `eval` instructions, the stats were emitted "too slowly",
and some tests expect metrics to be available sooner. The update to the
Makefile ensures that stats are emitted "quickly". Those instructions
are borrowed from the CI scripts in bin/

The expectations in the test prevent a panic when the stats are not
emitted fast enough.
@michaelklishin michaelklishin merged commit 5f9eab4 into michaelklishin:main Oct 30, 2024
2 checks passed
@Zerpet Zerpet deleted the add-deprecated-features branch October 31, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants