Adding Eth1 connections data message to service definition #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
…rysmaticlabs#10044) * Rename BeaconStateMerge to BeaconStateBellatrix * Rename version.Merge to version.Bellatrix * Rename ComputeFieldRootsWithHasherMerge to ComputeFieldRootsWithHasherBellatrix * Rename test names to Bellatrix * Rename comments and strings to Bellatrix * Fix formatting in a few files * Revert wrong renaming in test name * Revert renaming to Bellatrix in mainnet_config.go * Revert renaming of db key without migration * Regenerate from proto changes * Rename new use of already renamed symbols * gofmt and goimports after regenerating protofiles * revert weird imports Co-authored-by: prestonvanloon <preston@prysmaticlabs.com>
* Add merge spectests * fix build * gazelle * operation * all tests should pass * go fmt * fix test * fix dependency * rm unused constants * rename to bellatrix * Gaz * Rm unused files * Use Bellatrix for test names * Add more spec tests * Gaz and fix test * sync with dev * Preston's feedback * Go fmt * sync with dev Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
rauljordan
reviewed
Jan 10, 2022
beacon-chain/powchain/service.go
Outdated
| @@ -88,6 +88,10 @@ type ChainStartFetcher interface { | |||
| type ChainInfoFetcher interface { | |||
| Eth2GenesisPowchainInfo() (uint64, *big.Int) | |||
| IsConnectedToETH1() bool | |||
| CurrentEndpoint() string | |||
There was a problem hiding this comment.
Recommend calling these CurrentETH1Endpoint for extra clarity, same with Endpoints() becoming ETH1Endpoints()
proto/prysm/v1alpha1/node.proto
Outdated
| // // Retrieve the status of the ETH1 connections. | ||
| rpc GetETH1ConnectionStatus(google.protobuf.Empty) returns (ETH1ConnectionStatus) { | ||
| option (google.api.http) = { | ||
| get: "/eth/v1alpha1/node/eth1connections" |
There was a problem hiding this comment.
Suggested change
| get: "/eth/v1alpha1/node/eth1connections" | |
| get: "/eth/v1alpha1/node/eth1/connections" |
|
Closing to open PR on actual repo |
rkapka
pushed a commit
that referenced
this pull request
Feb 9, 2022
* Add DeleteBlock() * Raul review #1 * Update comments Co-authored-by: terence tsao <terence@prysmaticlabs.com>
terencechain
pushed a commit
that referenced
this pull request
Feb 12, 2022
) * Load Synced Tips when starting from Finalized State * Terence's review #1 * Fix tests Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
michaelneuder
pushed a commit
that referenced
this pull request
Apr 17, 2022
* Remove synced tips use last valid hash in removing invalid nodes. * add test * Remove unused code * More unused parameters * Fix proposer boost * terence's review #1 * Fix conflicts * terence's review 2 * rename argument * terence's review #3 * rename optimistic -> status * Minor clean up * revert loop variable change * do not mark lvh as valid Co-authored-by: terence tsao <terence@prysmaticlabs.com>
michaelneuder
pushed a commit
that referenced
this pull request
Aug 20, 2022
* Check for SIGILL before using gohashtree * gohashtree dep * check error * move to config startup * Kasey's advice * review #1 Co-authored-by: Raul Jordan <raul@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review