refactor(extractor): reduce code duplication and improve PEP8 compliance #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
extractor.pymodule to reduce code duplication, improve docstring clarity, and ensure PEP8 compliance.Changes
Code Duplication Reduction
_init_base_attributes()- Helper function to consolidate common initialization logic shared betweenExtractorandVideoExtractorclasses_get_stream()- Centralizes logic for retrieving stream info from eitherstreamsordash_streams_run_download()- Consolidates the nearly identical code fromdownload_by_urlanddownload_by_vid_sort_streams()- Extracts the complex stream sorting logic_get_stream_id_key()- Eliminates the repeatedstream['id'] if 'id' in stream else stream['itag']pattern_select_best_stream_id()- Extracts best stream selection logic_save_auxiliary_files()- Consolidates danmaku and lyrics file savingPEP8 Compliance
except:to specificexcept KeyError:match1,get_content)Docstring Improvements
Pull Request opened by Augment Code with guidance from the PR author