Improve FLV file handling to manage corrupted files gracefully #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances the
join_flv.pymodule to handle corrupted FLV files properly during the merging process. Instead of failing when encountering corrupted files, the module now validates each file, skips invalid ones, and continues with valid files.Changes
Added
validate_flv()function to check file integrity before processingtest_join_flv_validation.pywith extensive test casesModified
read_flv_header(),read_tag(), andread_meta_tag()to return meaningful values instead of raising exceptionsconcat_flv()to validate files, skip corrupted ones, and provide informative warningsguess_output()to better handle common filename patternsmain()function with proper error handlingFixed
Testing
Added comprehensive tests for all validation scenarios including:
All tests pass successfully, and the module now gracefully handles corrupted files while still producing valid output when possible.
Pull Request opened by Augment Code with guidance from the PR author
Pull Request opened by Augment Code with guidance from the PR author