Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting ingress/egress priority maps #160

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Support setting ingress/egress priority maps #160

merged 2 commits into from
Jul 16, 2024

Conversation

MoteHue
Copy link
Contributor

@MoteHue MoteHue commented Mar 14, 2024

No description provided.

markgoddard
markgoddard reviewed Mar 18, 2024
View reviewed changes
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these settings make sense on a bond or bridge interface?

markgoddard
markgoddard reviewed Mar 18, 2024
View reviewed changes
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the README with an example?

@MoteHue
Copy link
Contributor Author

MoteHue commented Mar 18, 2024 •
edited
Loading

Would these settings make sense on a bond or bridge interface?

Yes I believe so, afaik these can be applied in the same situations a VLAN id can. I've been testing with both bridges and bonded interfaces and haven't seen issues with applying the options. I misunderstood your question I think, will get back to you.

@MoteHue MoteHue changed the title Support setting ingress/egress priority map in NM Support setting ingress/egress priority maps Mar 19, 2024
@oneswig
Copy link
Contributor

oneswig commented Jul 12, 2024

Would these settings make sense on a bond or bridge interface?

No - it has to be a VLAN interface. The QOS bits are 3 bits at the top of a VLAN tag.

@markgoddard
Copy link

Would these settings make sense on a bond or bridge interface?

No - it has to be a VLAN interface. The QOS bits are 3 bits at the top of a VLAN tag.

Of course.

@markgoddard markgoddard merged commit 58f01e9 into michaelrigart:master Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoteHue @oneswig @markgoddard