Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up connection shutdown #487

Merged
merged 1 commit into from
May 5, 2022
Merged

Speed up connection shutdown #487

merged 1 commit into from
May 5, 2022

Conversation

slobo
Copy link
Contributor

@slobo slobo commented May 3, 2022

We have an issue where producing PDFs with remote images experiences 10s delay when trying to close the connection.

To my understanding, always using _WR should be good enough for our purposes - it tells remote we are done but doesn't needlessly wait for the remote to acknowledge it.

michaelrsweet
michaelrsweet approved these changes May 5, 2022
View reviewed changes
Copy link
Owner

@michaelrsweet michaelrsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. A similar change was made in CUPS a little while back, so it should be safe enough.

@michaelrsweet michaelrsweet self-assigned this May 5, 2022
@michaelrsweet michaelrsweet added enhancement New feature or request platform issue Issue is specific to an OS or desktop priority-low labels May 5, 2022
@michaelrsweet michaelrsweet added this to the Stable milestone May 5, 2022
@michaelrsweet michaelrsweet merged commit d5c7afd into michaelrsweet:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelrsweet michaelrsweet michaelrsweet approved these changes

Assignees

@michaelrsweet michaelrsweet

Labels
enhancement New feature or request platform issue Issue is specific to an OS or desktop priority-low
Projects
None yet
Milestone
Stable
Development

Successfully merging this pull request may close these issues.
2 participants
@slobo @michaelrsweet