lprint.c: Enable TLS support in Web UI #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Jul 30, 2024
|
@michaelrsweet thanks! It should be okay now. |
michaelrsweet
requested changes
Aug 21, 2024
|
I was not able to come up with one line expression which would be readable for me, feel free to check. |
michaelrsweet
requested changes
Sep 4, 2024
Currently (1.3.1) there is no way how to turn TLS web UI pages, because system callback does not set WEB_TLS option by default, and checks only for `no-tls` when processing server options. This can be fixed by two way, depending on which default settings we prefer. The PR enables TLS pages by default, leaving to user whether he wants them to be disabled. Disabling is done by removing WEB_TLS from PAPPL options and adding NO_TLS instead.
michaelrsweet
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently (1.3.1) there is no way how to turn TLS web UI pages, because system callback does not set WEB_TLS option by default, and checks only for
no-tlswhen processing server options.This can be fixed by two way, depending on which default settings we prefer. The PR enables TLS pages by default, leaving to user whether he wants them to be disabled.
Do let me know if you would prefer the other way around.