Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing spaces in ArmA 3 username #1003

Closed
bovine3dom opened this issue Aug 18, 2015 · 6 comments
Closed

Trailing spaces in ArmA 3 username #1003

bovine3dom opened this issue Aug 18, 2015 · 6 comments
Assignees
Milestone

Comments

@bovine3dom
Copy link

ArmA 3 lets you use trailing spaces in profile names. TeamSpeak does not. This causes TeamSpeak to spam "username already exists" when you join a game server.

Could TFR inform the user of the issue? Would probably save somebody somewhere a headache.

@dedmen
Copy link
Collaborator

dedmen commented Sep 16, 2016

The rename system should be reworked anyway.

  1. Is the renaming really needed?
  2. Trim strings so they are allowed by teamspeak
  3. Implement own name conflict check to make sure setting the name doesnt error out
  4. Handle errors on setting the name.

@dedmen
Copy link
Collaborator

dedmen commented Sep 19, 2016

Im currently solving this but. Im fighting between removing trailing spaces or replacing them with some char. Removing them would create problems if two players had the same ingame name only that one has a trailing space. Replacing them may look ugly.
Also i dont know what char to use when replacing. We have Unicode support so... That may be an interesting task.
For now im implementing it as replacing trailing spaces with a .

@dedmen dedmen modified the milestones: 1.0-refactor, 0.9.9 Sep 19, 2016
@dedmen dedmen added the testing label Sep 19, 2016
dedmen added a commit that referenced this issue Sep 19, 2016
@dedmen
Copy link
Collaborator

dedmen commented Sep 21, 2016

Fix is implemented in 1.0. Problem right now is I'm just replacing spaces with . that doesn't look that great though. And we cant just remove the spaces because that could create duplicate names. Can anyone suggest a nice UTF-8 char that I can use as a replacement? If not maybe I'll switch to _ or just remove the chars... Whats the chance anyway that one player is called "test" and another is called "test " but I'd prefer to obivate (just learned a new word) against new issue reports.

@zgmrvn
Copy link
Contributor

zgmrvn commented Sep 21, 2016

Alt+255, "unsplitable space" ?

@dedmen
Copy link
Collaborator

dedmen commented Sep 21, 2016

No teamspeak filters that.. We could use http://www.fileformat.info/info/unicode/char/2062/index.htm which is not filtered and invisible but.. Teamspeak may fix that

@dedmen
Copy link
Collaborator

dedmen commented Sep 30, 2016

I will replace trailing spaces with _
Currently teamspeak still produces an error on setting the client Nickname. Im not sure what causes that so I will keep this open till i solved that.
SetName is called on every FREQ command. Which come in rapid succession at first TFAR load. Tries to set name before teamspeak processed the previous set command

dedmen added a commit that referenced this issue Oct 17, 2016
@dedmen dedmen closed this as completed Oct 17, 2016
dedmen added a commit that referenced this issue Jun 17, 2019
Former-commit-id: e0f25c9fa89498ae15d4f0b321f2a86f7520d1a5 [formerly 0e2f202d119a441c08c894e008d9a1ca57c8b20a] [formerly 778d3cb44517893466ad0483374b9b7c0f287a5b [formerly 31b075386bcab3700cb6b71f5fa84107d1684f50]] [formerly 2a251b9b8529b38fe1383fc070a95c47986c5b81 [formerly 8563949bc5cc4e604b9f8976ed903b6185a6cfd4] [formerly 7a7f1590767a24738a03cf92fae1aade81c0e9cf [formerly a98766e61ca3921aed8b47ce5dc2633e10bb0a49]]]
Former-commit-id: fadb4f4f093799743589b6ba71359988ca6978a3 [formerly 01c487b9385360d22424d6a8f5fc8f1a45dbe9dc] [formerly b0332a6315b669d75c66f35ea93fa68b0802bfb8 [formerly 44dd2ba59647857f40471b09149e2751305a3ab7]]
Former-commit-id: e1bd9f630d6c3c3cc839554de55965bc57294f6e [formerly 8c55531958b086f78a38e6bcfb50a0947142c21e]
Former-commit-id: 49388cd50d7cdc4f199bd731641659929813c286
dedmen added a commit that referenced this issue Jun 17, 2019
Fixed #1003

Former-commit-id: 87c83df285d415a4a6e331c1e4a5febb0bd491ec [formerly 1ff802e0ef11815dd8a48a306a078b321b4a93fb] [formerly dc7eec3cda051c0f5120a8bc5109ad0a7e472de2 [formerly 8bdaeeccc41149ec1fa0c58a2b27dd4c2733e96a]] [formerly 2c111322c638fde9169f85725260995ce0a39ab2 [formerly 1c692e09fa021a9b90b9b2295066833dd86c3497] [formerly 86342bf66b78c4fbce6b7c34035c1ef5706eb7da [formerly 5a61daee545bac31d60030a0692d5d5544d2333d]]]
Former-commit-id: 86ead115dc1ec37389296641a55d7b3c4a76db54 [formerly 5b15906157ed6339f1beb8624b6bcfac8e7cf1ef] [formerly e9a239ef7a91f34d6eb300cbb104ec8828e58f01 [formerly 416aaf636b9dc6098dae971e190340d83b9b3241]]
Former-commit-id: 2e18f3c6836d12fdcb87837662b7c7b3857b789d [formerly caedc8d5c88a58f4e154bb0e429907f45759081d]
Former-commit-id: 92fbf0ad84b75f89cb94cc2a8710f731928c9718
dedmen added a commit that referenced this issue Jun 17, 2019
Former-commit-id: e0f25c9fa89498ae15d4f0b321f2a86f7520d1a5 [formerly 0e2f202d119a441c08c894e008d9a1ca57c8b20a] [formerly 778d3cb44517893466ad0483374b9b7c0f287a5b [formerly 31b075386bcab3700cb6b71f5fa84107d1684f50]] [formerly 2a251b9b8529b38fe1383fc070a95c47986c5b81 [formerly 8563949bc5cc4e604b9f8976ed903b6185a6cfd4] [formerly 7a7f1590767a24738a03cf92fae1aade81c0e9cf [formerly a98766e61ca3921aed8b47ce5dc2633e10bb0a49]]]
Former-commit-id: fadb4f4f093799743589b6ba71359988ca6978a3 [formerly 01c487b9385360d22424d6a8f5fc8f1a45dbe9dc] [formerly b0332a6315b669d75c66f35ea93fa68b0802bfb8 [formerly 44dd2ba59647857f40471b09149e2751305a3ab7]]
Former-commit-id: e1bd9f630d6c3c3cc839554de55965bc57294f6e [formerly 8c55531958b086f78a38e6bcfb50a0947142c21e]
Former-commit-id: 49388cd50d7cdc4f199bd731641659929813c286
Former-commit-id: cfc780c
dedmen added a commit that referenced this issue Jun 17, 2019
Fixed #1003

Former-commit-id: 87c83df285d415a4a6e331c1e4a5febb0bd491ec [formerly 1ff802e0ef11815dd8a48a306a078b321b4a93fb] [formerly dc7eec3cda051c0f5120a8bc5109ad0a7e472de2 [formerly 8bdaeeccc41149ec1fa0c58a2b27dd4c2733e96a]] [formerly 2c111322c638fde9169f85725260995ce0a39ab2 [formerly 1c692e09fa021a9b90b9b2295066833dd86c3497] [formerly 86342bf66b78c4fbce6b7c34035c1ef5706eb7da [formerly 5a61daee545bac31d60030a0692d5d5544d2333d]]]
Former-commit-id: 86ead115dc1ec37389296641a55d7b3c4a76db54 [formerly 5b15906157ed6339f1beb8624b6bcfac8e7cf1ef] [formerly e9a239ef7a91f34d6eb300cbb104ec8828e58f01 [formerly 416aaf636b9dc6098dae971e190340d83b9b3241]]
Former-commit-id: 2e18f3c6836d12fdcb87837662b7c7b3857b789d [formerly caedc8d5c88a58f4e154bb0e429907f45759081d]
Former-commit-id: 92fbf0ad84b75f89cb94cc2a8710f731928c9718
Former-commit-id: a4ae102
dedmen added a commit that referenced this issue Jun 17, 2019
dedmen added a commit that referenced this issue Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants