Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-Duplex support #1148

Merged
merged 6 commits into from
Oct 18, 2016
Merged

Half-Duplex support #1148

merged 6 commits into from
Oct 18, 2016

Conversation

dedmen
Copy link
Collaborator

@dedmen dedmen commented Oct 12, 2016

Fixes #519
For review by other devs.

@dedmen dedmen added this to the 1.0 milestone Oct 12, 2016
@dedmen dedmen self-assigned this Oct 12, 2016
!task_force_radio::config.get<bool>(Setting::full_duplex) &&
senderData->frequency.compare(serverIdToData[serverConnectionHandlerID].currentTransmittingFrequency)) {
/*
We are on half-duplex and currently transmitting on the incoming frequency. So we can't hear the other sender.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe pass radio id with freqs and use it for this problem?

Copy link
Collaborator Author

@dedmen dedmen Oct 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible but i tried to keep it as low "impact" as possible. Currently the new Plugin is still compatible with the old Arma files.
But yeah. Would probably better to use the full radio classname as currently transmitting instead of freq.
even better for the plugin would be to add it to the TANGENT command. That way i don't have to iterate through all frequencies to find the radio classname

Conflicts:
	addons/core/functions/fnc_ClientInit.sqf
	addons/core/functions/fnc_onAdditionalSwTangentPressed.sqf
@dedmen
Copy link
Collaborator Author

dedmen commented Oct 12, 2016

Done. But I'm tired and thats untested.
Also doesn't support DD radio because that doesn't actually have frequencies but instead only one string variable. But thats supposed to be removed in 1.0 anyway.

@dedmen dedmen merged commit a53f1be into 1.0 Oct 18, 2016
@dedmen dedmen deleted the feature/halfDuplex branch October 18, 2016 13:10
@treendy
Copy link

treendy commented May 5, 2019

really like to use this feature, but been looking everywhere... no documentation or details on where this setting is set? (cant see it in the GUI, cant see any settings file in the pbo?)
How do i enable this feature?

@treendy
Copy link

treendy commented May 6, 2019

ignore that... found it on steam workshop, beta version.
and it is all in the GUI! : )
Thanks for this amazing update, cant wait to try it out!
https://steamcommunity.com/sharedfiles/filedetails/?id=894678801

dedmen added a commit that referenced this pull request Jun 17, 2019
* Added half_duplex
* Added module and CBA duplex setting
* Changed from FREQ block to Radio block

Former-commit-id: 7dfdb7a5d07825444332ff58f4a9e78b13de6124 [formerly f0a0c5a754a0e43735629a114f73bd6bced5e6f5] [formerly 4e1bab2ad17837f2d8fe26ebcb8bd93787d859d6 [formerly 560c26adc07d9593be655fd19d25c1665f076c78]] [formerly a5b2986fbf6a8d2d870ad06c7af72db4ee47bad0 [formerly 83489bc755bd5412a35fb6e1298894b7fac5663b] [formerly 36ed462751c435c7eefc31d2fff0a4e0534b03e6 [formerly d081860475eda256bbd128821a0019cf0ff51910]]]
Former-commit-id: 22df6dfa13c7de2ae72a7d7290829e568d6fd4c6 [formerly 58c87fb4b49c5016c19d2984eb5f8ec685697b1d] [formerly 995d6234e26598598aacff9d5954db88fcf24929 [formerly ec007f75b34e11d2b3b4887b35ce49031e36d576]]
Former-commit-id: ec86eeaa5ae7b07ef694bf274dd4e7f743532873 [formerly bb296b030572478ea2b674dea5476baafb286c68]
Former-commit-id: 53befecb5cb3d725f7111c3a62211d082cddc39f
dedmen added a commit that referenced this pull request Jun 17, 2019
* Added half_duplex
* Added module and CBA duplex setting
* Changed from FREQ block to Radio block

Former-commit-id: 7dfdb7a5d07825444332ff58f4a9e78b13de6124 [formerly f0a0c5a754a0e43735629a114f73bd6bced5e6f5] [formerly 4e1bab2ad17837f2d8fe26ebcb8bd93787d859d6 [formerly 560c26adc07d9593be655fd19d25c1665f076c78]] [formerly a5b2986fbf6a8d2d870ad06c7af72db4ee47bad0 [formerly 83489bc755bd5412a35fb6e1298894b7fac5663b] [formerly 36ed462751c435c7eefc31d2fff0a4e0534b03e6 [formerly d081860475eda256bbd128821a0019cf0ff51910]]]
Former-commit-id: 22df6dfa13c7de2ae72a7d7290829e568d6fd4c6 [formerly 58c87fb4b49c5016c19d2984eb5f8ec685697b1d] [formerly 995d6234e26598598aacff9d5954db88fcf24929 [formerly ec007f75b34e11d2b3b4887b35ce49031e36d576]]
Former-commit-id: ec86eeaa5ae7b07ef694bf274dd4e7f743532873 [formerly bb296b030572478ea2b674dea5476baafb286c68]
Former-commit-id: 53befecb5cb3d725f7111c3a62211d082cddc39f
Former-commit-id: 9d6ef78
dedmen added a commit that referenced this pull request Jun 17, 2019
* Added half_duplex
* Added module and CBA duplex setting
* Changed from FREQ block to Radio block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants