Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keybinds for different speech volumes #887 #992

Merged
merged 7 commits into from
Sep 23, 2016
Merged

Add keybinds for different speech volumes #887 #992

merged 7 commits into from
Sep 23, 2016

Conversation

ACyprus
Copy link
Contributor

@ACyprus ACyprus commented Aug 8, 2015

Adds a set of 'modifier' keys that allow a transient change in speaking volume whilst they are held down.

I've introduced one for yelling and one for whispering.

There are no default keybinds.

Holding down a modifier key while transmitting will change the speaking volume and display a relevant hint.

Releasing the modifier will remove the hint and reset the speaking volume to the previous setting.

NOTE: the key binds in configuration are currently called "Yelling Modifier" and "Whispering Modifier" - only because I couldn't think of a better phrase. I am open to suggestions - perhaps something that would place them next to "Change Speaking Volume" in the list.

I've tested this on dedicated and works well. Could do with some 'third party' testing.

Closes #887

@ACyprus
Copy link
Contributor Author

ACyprus commented Aug 8, 2015

PS: should I make this feature available to curator players?

@michail-nikolaev
Copy link
Owner

Sorry - on vacation now + lost my dig - will review probably tommorow

@ACyprus
Copy link
Contributor Author

ACyprus commented Aug 14, 2015

Thanks, No rush. Enjoy your vacation!

PS - when you're back, if you could let me know how I might initiate direct speech from the plugin (is there a callExtension mode?) then I can change these from just modifier keys to actual send speech keys. (Unless you meant you need to update the plugin first)

@ACyprus ACyprus closed this Sep 29, 2015
@ACyprus ACyprus reopened this Sep 29, 2015
@kavinsky kavinsky added this to the 1.0-refactor milestone Sep 18, 2016
@kavinsky kavinsky self-assigned this Sep 18, 2016
@dedmen dedmen changed the base branch from master to 1.0 September 20, 2016 21:27
@dedmen
Copy link
Collaborator

dedmen commented Sep 20, 2016

We are ready to merge this.
You could probably force voice transmission by calling the extension command
TANGENT PRESSED frequeny range radiotype
the fifth parameter is the radio type (SW,LR,airborne,diver) if you pass an unknown type it wont create any radio sounds but would still transmit voice. But that may trigger the radio receive sound on other players. But if you just set the frequency to 0 it wont trigger the incomming transmission sound.

Currently there its not possible to call TFAR_fnc_ProcessTanget and tell it to not show a Hint.
So you have to

if (isMultiplayer) then {
    "task_force_radio_pipe" callExtension format["TANGENT   PRESSED %1  %2  %3",frequency,range,subtype];
};

Manually for now. Mind that the spaces are actually tabs (\t).
But i would prefer to merge this now as just modifier keys and then later implement actually activating voice transmission. After the restructuring is done. Implement it if you want but if you dont answer quick enough we will just merge this as it is.

But i would also let the user decide whether he just wants it as a modifier key or full blown push-to-talk key.

I have added a list of stuff we have to do on this later in #1111 (comment)
@kavinsky Feel free to merge this for now so this doesnt hold of the rest of 1.0 work. We will do the changes i explained above later.

@dedmen
Copy link
Collaborator

dedmen commented Sep 23, 2016

just for reference...... It doesn't work correctly when you switch between the modifier keys as fast as you can...

@kavinsky kavinsky merged commit d28f23b into michail-nikolaev:1.0 Sep 23, 2016
dedmen pushed a commit that referenced this pull request Jun 17, 2019
* function declaration for #887

* Revert "function declaration for #887"

This reverts commit 7b24165.

* function definition for #887

* functions code for #887

* keybind definitions and constants for #887

* scancode definitions for new keybinds in #887

* didn't need to maintain pressed state after all


Former-commit-id: cdc79969b9f492a608da54e2d37be40eda80555e [formerly 51e3f7df4bdd82e5458cdafa1227a4a2293cba1e] [formerly ea6a968a14463b41b6799a25d4cfc03644b927cf [formerly 2269f41c4a0a126ef9eb1300d7a25b327992c9e4]] [formerly 1ead95ae89c6bb52492096c377e0d49e9c45f6d8 [formerly 09bacff7e72dfc248892b7af55fb1f8fa4b5de98] [formerly eb8bbbf5d27d4744010423a337b0932c30424d41 [formerly e1ff1a16053dbd9d83ac9a2cbddc92e7fa512f0e]]]
Former-commit-id: ea7a04203adcf3d7811b18f23ef6dcfe12ecca52 [formerly e115af6322f0dbc73468842ef7f670b610372268] [formerly 89c65d3937eb8951baf0bab33336ae49bb8db9ab [formerly bee8d8e30a089553b692a2a0c9028a6c45f2fb66]]
Former-commit-id: 23c15924c4fcc58df2e329ac16ce94f9be9d6f93 [formerly ca51a2b38bce86db092520d5e765d5c119a57cf2]
Former-commit-id: 48abf138c26b670e0aab1fa453a3ad9a251995e1
dedmen pushed a commit that referenced this pull request Jun 17, 2019
* function declaration for #887

* Revert "function declaration for #887"

This reverts commit 7b24165.

* function definition for #887

* functions code for #887

* keybind definitions and constants for #887

* scancode definitions for new keybinds in #887

* didn't need to maintain pressed state after all


Former-commit-id: cdc79969b9f492a608da54e2d37be40eda80555e [formerly 51e3f7df4bdd82e5458cdafa1227a4a2293cba1e] [formerly ea6a968a14463b41b6799a25d4cfc03644b927cf [formerly 2269f41c4a0a126ef9eb1300d7a25b327992c9e4]] [formerly 1ead95ae89c6bb52492096c377e0d49e9c45f6d8 [formerly 09bacff7e72dfc248892b7af55fb1f8fa4b5de98] [formerly eb8bbbf5d27d4744010423a337b0932c30424d41 [formerly e1ff1a16053dbd9d83ac9a2cbddc92e7fa512f0e]]]
Former-commit-id: ea7a04203adcf3d7811b18f23ef6dcfe12ecca52 [formerly e115af6322f0dbc73468842ef7f670b610372268] [formerly 89c65d3937eb8951baf0bab33336ae49bb8db9ab [formerly bee8d8e30a089553b692a2a0c9028a6c45f2fb66]]
Former-commit-id: 23c15924c4fcc58df2e329ac16ce94f9be9d6f93 [formerly ca51a2b38bce86db092520d5e765d5c119a57cf2]
Former-commit-id: 48abf138c26b670e0aab1fa453a3ad9a251995e1
Former-commit-id: dbc78d8
dedmen pushed a commit that referenced this pull request Jun 17, 2019
* function declaration for #887

* Revert "function declaration for #887"

This reverts commit 7b24165.

* function definition for #887

* functions code for #887

* keybind definitions and constants for #887

* scancode definitions for new keybinds in #887

* didn't need to maintain pressed state after all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants