feat(next): migrate to TypeScript #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalchudziak
changed the title
dratwas
reviewed
May 19, 2022
js/implementation.native.ts
Outdated
Comment on lines
66
to
68
| geo_success: (position: GeolocationResponse) => void, | ||
| geo_error?: (error: GeolocationError) => void, | ||
| geo_options?: GeolocationOptions |
There was a problem hiding this comment.
is the geo prefix necessary?
dratwas
approved these changes
May 19, 2022
michalchudziak
force-pushed
the
feat/revamp-typescript
branch
from
4a796ff to
5bff95c
Compare
michalchudziak
added a commit
that referenced
this pull request
Sep 14, 2022
* chore(example): update example file structure (#77) * chore(example): update example file structure to make it compatible with the tester * fix(example): lint and type errors * chore(deps): bump npm-user-validate from 1.0.0 to 1.0.1 (#126) Bumps [npm-user-validate](https://github.com/npm/npm-user-validate) from 1.0.0 to 1.0.1. - [Release notes](https://github.com/npm/npm-user-validate/releases) - [Commits](npm/npm-user-validate@v1.0.0...v1.0.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add location extras support (#144) * refactor(next): update React Native and other dependencies, recreate example app (#176) * chore: update dependencies and example app setup * chore: remove native tests from example * feat(next): migrate to TypeScript (#178) * chore: update dependencies and example app setup * chore: remove native tests from example * chore: rename files to TS * chore: migrate to typescript * chore: add ts to example app and tests * chore: fix types imports * refactor: remove geo prefixes * chore: minor improvements * chore: upgrade RN to 69 (#183) * Add support for TurboModules (#184) * chore: upgrade RN to 69 * chore: turbomodule support for iOS * chore: turbomodules for android scaffold * chore: turbomodule support for Android * chore: remove unnecessary setting * chore: link cpp module manually * chore: cleanup * Add support for Google’s Location Services API (#185) * feat(android-backend): refactor module * feat(android): play services manager * feat(android): fix permission crash * Revamp example app (#186) * feat(android-backend): refactor module * feat(android): play services manager * feat(android): fix permission crash * feat(example): new example * feat(example): new example * feat(request-auth): add support for Android (#187) * feat(request-auth): add support for Android * fix(request-auth): fix location callback creation * fix(request-auth): add error to callback * fix(request-auth): queue quth callbacks * chore(readme): update readme Co-authored-by: Bartol Karuza <bartol.k@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tony Gomez <4647760+tonygomez@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is a part of the ongoing library revamp effort. It consists of the complete removal of Flow and replacing it with TypeScript. Additionally I cleaned up the eslint and prettier configs.
Test Plan
cd example && npx react-native run-ios)cd example && npx react-native run-android)yarn prepareworks