Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set background location enabled if not requesting permissions #232

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Set background location enabled if not requesting permissions #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions ios/RNCGeolocation.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ - (void)beginLocationUpdatesWithDesiredAccuracy:(CLLocationAccuracy)desiredAccur
{
if (!_locationConfiguration.skipPermissionRequests) {
[self requestAuthorization:nil error:nil];
} else {
[self enableBackgroundLocationUpdates];
}

if (!_locationManager) {
Expand Down Expand Up @@ -271,19 +273,24 @@ - (void)timeout:(NSTimer *)timer
// Request location access permission
if (wantsAlways) {
[_locationManager requestAlwaysAuthorization];

// On iOS 9+ we also need to enable background updates
NSArray *backgroundModes = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"UIBackgroundModes"];
if (backgroundModes && [backgroundModes containsObject:@"location"]) {
if ([_locationManager respondsToSelector:@selector(setAllowsBackgroundLocationUpdates:)]) {
[_locationManager setAllowsBackgroundLocationUpdates:YES];
}
}
[self enableBackgroundLocationUpdates];
} else if (wantsWhenInUse) {
[_locationManager requestWhenInUseAuthorization];
}
}

- (void)enableBackgroundLocationUpdates
{
// iOS 9+ requires explicitly enabling background updates
NSArray *backgroundModes = [[NSBundle mainBundle] objectForInfoDictionaryKey:@"UIBackgroundModes"];
if (backgroundModes && [backgroundModes containsObject:@"location"]) {
if ([_locationManager respondsToSelector:@selector(setAllowsBackgroundLocationUpdates:)]) {
[_locationManager setAllowsBackgroundLocationUpdates:YES];
}
}
}


RCT_REMAP_METHOD(startObserving, startObserving:(RNCGeolocationOptions)options)
{
checkLocationConfig();
Expand Down