Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when using playServices provider the getCurrentPosition error callback is never called #302

Conversation

ekbaumgarten
Copy link
Contributor

When using playServices provider the getCurrentPosition error callback is never called

Overview

In Android platform, when you are using the playServices as location provider and any error occurs in checkLocationSettings phase, it always emits the geolocationError event, which is only listenned by the watchPosition feature. So, when you are using the getCurrentPosition feature, the error callback is never being called.

Test Plan

Using the example project in this repository, do the following:

  1. Turn off the device location (GPS)
  2. Select playServices as the location provider
  3. Go to Examples screen and click on the getCurrentPosition button.
  4. A GetCurrentPosition Error alert will be shown.

@generosocarbone
Copy link

Any news on this?

Copy link
Owner

@michalchudziak michalchudziak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR

@michalchudziak michalchudziak merged commit 3a4431d into michalchudziak:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants