Enabled ttxt as a lib #22
Conversation
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
...updated packages, made the crate a lib too Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
…michalkucharczyk#20) * fix: make derivation path compatible with pallet-balances devAccounts Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> * remove SEED const Signed-off-by: Iulian Barbu <iulian.barbu@parity.io> --------- Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
| pub mod scenario; | ||
| pub mod subxt_api_connector; | ||
| pub mod subxt_transaction; | ||
| pub mod transaction; |
There was a problem hiding this comment.
One more clean-up that could be done in this PR is exposing only what is required in zombienet / main.
There was a problem hiding this comment.
Zombienet tests will need the ScenarioBuilder, ScenarioExecutor, the DefaultTxTask and the transaction types: EthTransaction & SubstrateTransaction.
main.rs needs a few more.
There are a few more types that can be limited to pub(crate) or maybe remove pub(crate) altogether, but if done so Rust compiler complains that these types are related to other types that have higher visibility (meaning pub). In practice we can lower the visibility for all the types that are not directly used in main.rs & zombienet tests, and suppress the associated visibility warnings (which are a lot), but I decided to expose the types that rust compiler complains about, even if not directly used. I wouldn't overindex on the pub API that much, considering the way zombienet tests will be developed will rely on the types I mentioned. The rest of the types can extend ttxt for library users (e.g. add new tx builder, sink & txs), but at this time we're the only users.
I wouldn't publish ttxt on crates.io yet, but use it based on a git dependency in our tests for a bit of time until we decide more on how the API should look like (and after raising a bit more the tests coverage). WDYT?
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>
|
In latest batch of commits I added:
|
| .with_send_threshold(*send_threshold as usize) | ||
| .with_block_monitoring(*block_monitor) | ||
| .with_watched_txs(!unwatched) | ||
| .with_tip(*tip); |
There was a problem hiding this comment.
tip could be overwritten by lines 74-75 (remark recipe setting).
Maybe tip should be a dedicated field in ScenarioBuilder - otherwise it could be overwritten when recipe is set after. (or should be moved from old recipe when new is set).
| .with_send_threshold(*send_threshold as usize) | ||
| .with_block_monitoring(*block_monitor) | ||
| .with_watched_txs(!unwatched) | ||
| .with_tip(*tip); |
Made the crate as a lib (in addition to being a binary) but..
Did a bunch on unnecessary changes too:
polkadot-sdkaccount_id()call on keyring, and usepublic_key()instead. I think this should be alright but lmk if you have another opinion.I can revert the unnecessary changes if you want or find it important for some reason.
Closes #18