Pass event and lambdaContext to onConnect function #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthentication flow.
michalkvasnicak
approved these changes
Feb 14, 2020
michalkvasnicak
requested changes
Feb 14, 2020
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Done. |
michalkvasnicak
approved these changes
Feb 14, 2020
|
@nenti thank you, released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a proper authorization flow the context variable passed into the lambda functions are important because they contain the response of the authorization function. The easiest way to solve this with this library is attaching auth context to the connection database entry through the onConnect function. Apparently in the current version this is not possible because the lambda context is not passed into the onConnect function. This pull request fixes this by adding the lambda context as additional variables to the onConnect function.