Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both new and legacy Context APIs #72

Merged
merged 4 commits into from
Oct 10, 2018

Conversation

michalochman
Copy link
Owner

@michalochman michalochman commented Sep 12, 2018

This PR updates <Stage /> component to work for both new and legacy Context APIs.

TODO:

  • fix unit tests
  • add tests for context provider

Fixes #71

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #72 into master will decrease coverage by 4.36%.
The diff coverage is 67.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage     100%   95.63%   -4.37%     
==========================================
  Files          10       11       +1     
  Lines         206      229      +23     
==========================================
+ Hits          206      219      +13     
- Misses          0       10      +10
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/render.js 100% <100%> (ø) ⬆️
src/Stage.js 100% <100%> (ø) ⬆️
src/AppProvider.js 60% <60%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13284e2...b2ef8fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant