fix(service): add return type for uuid service to satisfy phpstan #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassinedoghri
force-pushed
the
fix/phpstan-error
branch
from
bbff7c3
to
1d5eeb6
Compare
|
Thank you. Well, this project needs some love... maybe one day 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @michalsn,
I'm currently working on including the new
phpstan-codeigniterextension to Castopod and hadphpstancomplain because theuuidservice is missing a return type:Decided to set the return type in a docstring as I'm not sure it works as a return type in PHP 7.3
On another note, I think this project should not be supporting php 7.3 and even 7.4 as their EOL has passed. + CodeIgniter is in the talks about dropping a few deprecated versions as well! (codeigniter4/CodeIgniter4#6921, codeigniter4/CodeIgniter4#7320)
Thank you again for this library, I use it everywhere! 🙂