Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Make preview close button placement follow system's setting #1918

Closed
hyuri opened this issue Feb 20, 2023 · 4 comments · Fixed by #1943
Closed

[Feature] Make preview close button placement follow system's setting #1918

hyuri opened this issue Feb 20, 2023 · 4 comments · Fixed by #1943

Comments

@hyuri
Copy link

hyuri commented Feb 20, 2023 •
edited
Loading

Hi!

I'd like to suggest making the placement of the preview close button follow the user's chosen window buttons placement.

Right now it doesn't, making it inconsistent and breaking expectations.

You can see that my window buttons are placed on the left, but the preview close button is placed on the right:
ScreenShot_20230220-132913
@3v1n0
Copy link
Collaborator

3v1n0 commented Feb 24, 2023

While I agree that this is not super consistent, also it would imply changing the code of the overview... Which is possible but also increases the complexity and maintainability of the extension.

@hyuri
Copy link
Author

hyuri commented Feb 24, 2023

Is it supposed to follow the close button placement of the overview? The close button is placed left on my overview, it follows my placement setting. Maybe another extension is doing it... so I'm thinking that changing just dash-to-dock might suffice.

3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Feb 28, 2023
@3v1n0
windowPreview: Honor button layout settings for the window preview close
fcaa859 
Dispose the window previews close button left or right depending on the
button layout settings.

Closes: micheleg#1918
@3v1n0 3v1n0 mentioned this issue Feb 28, 2023
Merged
3v1n0 added a commit that referenced this issue Feb 28, 2023
@3v1n0
windowPreview: Honor button layout settings for the window preview close
c374d66 
Dispose the window previews close button left or right depending on the
button layout settings.

Closes: #1918
@vanvugt
Copy link
Collaborator

vanvugt commented Feb 28, 2023

☝️
Fixed in future version 79.

@hyuri
Copy link
Author

hyuri commented Mar 7, 2023

Awesome! Thank you @3v1n0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

windowPreview: Honor button layout settings for the window preview close 3v1n0/dash-to-dock
3 participants
@3v1n0 @vanvugt @hyuri