Support more Unity features (quicklist, urgent properties) #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some bad behavior I've observed with Unity badges getting stuck in an invalid state. The new code is much more graceful about event ordering and handing off control between multiple processes contending for a single launcher icon.
This adds support for the 'urgent' property from the Unity launcher API. Launcher icons marked as urgent get a short "dance" animation while the dock is visible.
|
Oh, nice work... I will review this a bit later in the cycle. But looks like a good thing to do and in my list as well. |
3v1n0
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Overall this looks great, I've been through the code and this seems to do things as they were expected to be.
So approving.
I've some ideal changes to do though:
- Make importing DBusmenu dynamic (may not be available in other distros than ubuntu)
- Change the animation mechanism (doesn't work in 3.38, but mostly could be simplified).
However, I've implemented both as ideally I was thinking about in https://github.com/3v1n0/dash-to-dock/commits/unity-features-improvements
Feel free to propose another MR if you have better ideas about.
Merging this for now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the two properties of a libunity LauncherEntry object not yet supported: "quicklist" and "urgent". Quicklist entries are added to the right-click menu of the launcher as dynamic menu items. The urgent flag, if set, gives the icon a short dancing animation to call attention to it. These features don't seem to be widely used by applications, but there's a bit of a chicken-and-egg problem here; why would application authors spend time writing code to use them if they aren't supported by the desktop?
I encountered some trouble with the libunity communication, and I also had some trouble understanding the intent of the original libunity integrating code, so I took the liberty of refactoring it into a pattern that, among other advantages, is more robust to multiple DBus applications contending for the same LauncherEntry. Hopefully you see it as an improvement too; I can try to back it out if not, but it did make adding these two features much easier.
I've been using this branch for the better part of a year now, and tested the new features with my own custom applications; it all has been working quite well for me. I hope it does some good for someone else.