Gnome 3.38: Mutter: Fix allocation-changed signal from Clutter

[aimproxy]

This PR replaces the alocation-changed signal by the original notification allocation. Clutter has no longer allocation-changed signal since they do not have from now allocation flags. This change is part of Gnome 3.38 milestone, u can check that out here: MR !1245

This PR should not affect anything in Gnome 3.36, because allocation notifications already exists in this version, u can merge it safely.

Also the Show Applications button does not work any more, in Gnome 3.37.2, I believe they have changed something in the Bus API, I just can't find the piece of code in your extension to check that, could you please tell me which functions perform the action to open the applications menu? So I can fix that out.

Sorry for my grammar.
And thx for this amazing extension!

[UA27]

@aimproxy Is that what you're looking for?

dash-to-dock/dash.js

Lines 219 to 228 in 0d54896

	// Create a wrapper around the real showAppsIcon in order to add a popupMenu.
	this._showAppsIcon = new AppIcons.MyShowAppsIcon();
	this._showAppsIcon.show();
	this._showAppsIcon.icon.setIconSize(this.iconSize);
	this._hookUpLabel(this._showAppsIcon);
	this._showAppsIcon.connect('menu-state-changed', (_icon, opened) => {
	this._itemMenuStateChanged(this._showAppsIcon, opened);
	});
	this._container.add_actor(this._showAppsIcon);

dash-to-dock/appIcons.js

Lines 1029 to 1035 in 0d54896

	var MyShowAppsIcon = GObject.registerClass({
	Signals: {
	'menu-state-changed': { param_types: [GObject.TYPE_BOOLEAN] },
	'sync-tooltip': {}
	}
	}
	, class DashToDock_MyShowAppsIcon extends Dash.ShowAppsIcon {

[aimproxy]

Not quite sure, u didn't mention any line on the code... I did this PR because when I was installed fedora rawhide the extension was not working properly cause of allocation flags. But now it works with the master version of the repo. I didn't have the time to read the code on the links, please mention a specific line so I can know what u talking about.

Sorry for my bad English 😂

[bubi-luka]

@aimproxy I have tried your fix and it works for me with the exception of Show Application button. Do you have any additional code to test for this button I can try? I can post a review of your PR, but that would probably not get your code merged, as I am not part of the team?

[aimproxy]

Well, I didn't figure out where was the code for the show application button, I didn't quite have the time to look more into the code. But I think it will be great testing the fix with the last version of gnome, and see what's really the problem is with the show application button.

[UA27]

@aimproxy where is the code for the Show Applications button is what I tried to highlight in my last comment. From what I gathered, lines 220-228 in the Dash.js file is where the Show Applications button is mounted onto the dock's container, but the extension uses a custom object extending Gnome Shell's real ShowAppsIcon. That object (meaning Dash to Dock's Show Applications button) is defined in the appIcons.js file starting at line 1029 and onwards.

If you (whenever you have time) - or anybody else - want to give a go at the Show Applications' bug.

[3v1n0]

LGTM.

Not sure still if it's possible to keep the codebase fully 3.36 compatible yet as per other changes, but maybe I'll include a string for the signal so that we can be version dependant.

Thanks

[zerocoolroot]

This PR replaces the alocation-changed signal by the original notification allocation. Clutter has no longer allocation-changed signal since they do not have from now allocation flags. This change is part of Gnome 3.38 milestone, u can check that out here: MR !1245

This PR should not affect anything in Gnome 3.36, because allocation notifications already exists in this version, u can merge it safely.

Also the Show Applications button does not work any more, in Gnome 3.37.2, I believe they have changed something in the Bus API, I just can't find the piece of code in your extension to check that, could you please tell me which functions perform the action to open the applications menu? So I can fix that out.

Sorry for my grammar.
And thx for this amazing extension!

aimproxy,

Sorry my bad english, I'm from Brazil..!!

I don't know how to apply this fix. How do i do..??

2a75ae4

Thanks in advance..!!

[aimproxy]

@zerocoolroot be sure u using gnome 3.38 on the last version, fork this repo on master and install it. Everything should be fine except for the Show Application Button. If you need more instructions just use @aimproxy to alert me on Github, I will answer as quickly as I can.

[aimproxy]

@3v1n0 No you can't, this change will brake dash to dock on 3.36, this fix is only for 3.37.+ 3.38.+!

[zerocoolroot]

@zerocoolroot be sure u using gnome 3.38 on the last version, fork this repo on this commit and install it. Everything should be fine except for the Show Application Button.

@aimproxy I installed the version from the link below and works fine for me. Included Show Application Button..!!

https://github.com/micheleg/dash-to-dock/tree/gnome-3-38

Fedora 33 Beta.

Thank you so much..!!

[aimproxy]

@zerocoolroot cool, someone fixes that for us! @3v1n0 Just to keep in mind, I know there is a lot of people reporting the same issue, you can now close the following issues: #1301 #1299

[3v1n0]

@3v1n0 No you can't, this change will brake dash to dock on 3.36, this fix is only for 3.37.+ 3.38.+!

Sure we can, both versions can be supported. JS is hacky enough to allow that :)