[dash-to-dock] Don't autohide while a menu is open #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanvugt
changed the title
Otherwise the previews menu would never trigger 'menu-opened' for DockDash. We need to emit it before calling this._previewMenu.popup() to prevent that call from triggering a hover-out and the dock immediately auto-hiding.
Losing the hover state is technically correct so it can't be the only
condition we check for. Also wait until the menu is closed before
resync'ing the hover state and auto-hiding.
This became necessary in GNOME 42 with the introduction of new grab APIs.
Perhaps because the old method we used for preventing auto-hide during
menus was removed:
ignoreRelease() {
- return this._grabHelper.ignoreRelease();
}
Fixes micheleg#1714
Fixes micheleg#1755
Fixes https://launchpad.net/bugs/1967121
vanvugt
force-pushed
the
fix-lp1967121-upstream
branch
from
d4909d0 to
77dac94
Compare
ewlsh
approved these changes
May 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1714, #1755 and https://launchpad.net/bugs/1967121
Also fixed in ubuntu-dock via #1739