Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to turn on/off show dock for urgent notifications #1780

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

leandrokemp
Copy link
Contributor

@leandrokemp leandrokemp commented Jul 25, 2022

This is to fix the issue: Prevent dock from popping out when gnome is in do-not-disturb #1634

The users will be able to choose in the intelligent hide settings whether they want the dock to be shown for urgent notifications or not.

@hmlendea
Copy link

This is the final (and big) issue I've had with Dash-to-Dock.
Hopefully this fix will be merged soon!

Thank you!!!

@leandrokemp leandrokemp force-pushed the show-dock-urgent-notify branch 2 times, most recently from 769ea3d to 090f8f9 Compare July 31, 2022 00:05
@leandrokemp
Copy link
Contributor Author

@micheleg Could you please review my changes?

Thank you in advance.

Copy link
Collaborator

@3v1n0 3v1n0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned the code a bit, thanks a lot!

@3v1n0 3v1n0 merged commit c0f806c into micheleg:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants