Fix Transparency for Gtk4 DING #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this creating any problem with the gtk3 version? |
|
No, seems to work with both the Gtk3 and Gtk4 branches on both X11 and
Wayland.
…On Wed, Feb 22 2023 at 06:16:08 PM -08:00:00, Marco Trevisan ***@***.***> wrote:
Is this creating any problem with the gtk3 version?
—
Reply to this email directly, view it on GitHub
<#1888 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWEICQAUP3755OUD5HWCYWTWY3B6RANCNFSM6AAAAAASZXXB6M>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Gtk4-DING, the Gtk4 port of the desktop icons extension, the desktop X11 window cannot be detected by "DESKTOP" type. It is handled by the same code as wayland windows, and needs to be detected by the skip_taskbar hint. This enables correct transparency of the dock when on X11 with Gtk4-DING.
This, works with #1879, which is needed for fixing intellihide of Dock with Gtk4-DING.