Hide tooltip #1953
Merged
Hide tooltip #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
reviewed
Mar 2, 2023
docking.js
Outdated
Comment on lines
577
to
582
| ], [ | ||
| settings, | ||
| 'changed::hide-tooltip', | ||
| () => { | ||
| this.dash.resetAppIcons(); | ||
| }, |
There was a problem hiding this comment.
I'm not sure this is needed, at the end this should be applied immediately once you hover the icon anyways.
There was a problem hiding this comment.
You are right, this is not needed.
Do you plan to accept this PR? Do I need to make a new one without docking.js change?
There was a problem hiding this comment.
No need a new PR, just remove this change, amend your commit and force push to github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide application tooltip option