Fix Startup infinite await #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need to keep our injected methods and signal connections around when the startup animation has completed.
…mation During startup animation the shell may receive a monitors-changed event, in this case the startup animation events are never triggered because the background loaded signal is never emitted. To prevent this, re-implement the update background code during the layout _prepareStartupAnimation so that we can catch monitor update events and react accordingly. See: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2763 LP: #2019751
3v1n0
force-pushed
the
startup-infinite-await-fix
branch
from
335cf4f to
bf1ace6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially under X11 we may get "monitors-changed" event while the startup animation is in progress, while some of them were addressed by !2269 (merged), we still have an issue happening:
GNOME shell is preparing the animation and awaiting for bg changes
Monitors are changed, during this phase we destroy the current background managers
=> The "loaded" signals we were waiting for, won't ever happen
This implies that we are stuck in
await this._updateBackgrounds(); and thus we keep staying in broken mode.Ubuntu issue is https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-ubuntu-dock/+bug/2019751 it can be simulated with https://gitlab.gnome.org/3v1n0/gnome-shell/-/snippets/5749
Similar to https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2763 but on the dock side