Skip to content

Commit

Permalink
test: skip tests with common.skip
Browse files Browse the repository at this point in the history
The `common.skip` function adds proper message in TAP format to skipped
tests. It is better not to have the message rewritten in the tests.

PR-URL: nodejs/node#11585
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
  • Loading branch information
thefourtheye authored and andrew749 committed Jul 19, 2017
1 parent 46c8649 commit aa871cb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-authenticated.js
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ for (const i in TEST_CASES) {
}

if (common.hasFipsCrypto && test.iv.length < 24) {
console.log('1..0 # Skipped: IV len < 12 bytes unsupported in FIPS mode');
common.skip('IV len < 12 bytes unsupported in FIPS mode');
continue;
}

Expand Down
6 changes: 2 additions & 4 deletions test/parallel/test-tls-empty-sni-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@
const common = require('../common');

if (!process.features.tls_sni) {
console.log('1..0 # Skipped: node compiled without OpenSSL or ' +
'with old OpenSSL version.');
common.skip('node compiled without OpenSSL or with old OpenSSL version.');
return;
}

const assert = require('assert');

if (!common.hasCrypto) {
console.log('1..0 # Skipped: missing crypto');
return;
return common.skip('missing crypto');
}

const tls = require('tls');
Expand Down

0 comments on commit aa871cb

Please sign in to comment.