Swap child and parent: prevent pplog immediate interrupt #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalyshatskikh
changed the title
vitalyshatskikh
changed the title
|
Do you have the problem on non-widows os? I have a test for linux. It seems everything is ok |
This was referenced Jun 13, 2024
|
When I created the PR, I was absolutely sure that I had checked Ubuntu on my machine. Known Windows problem - ok, let's close this PR and continue in #14 |
vitalyshatskikh
deleted the
swap-child-and-parent-prevent-pplog-immediate-interrupt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
If we get rid of signal handling at all, pplog will be stopped immediately on ctrl-c in the terminal, so it will not print logs during command shutdown
Solution:
Handle interrupt signal and allow target to shutdown gracefully, stop immediatly on the second interrupt
UPD:
need update tests, it works fine on local machine, but CI failed because of "set: can't access tty; job control turned off"
UPD2:
Github actions run without TTY, but there is a workaround: comment on issue 241