Compatibility with NuttX-11 #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, @robertobucher have you considered including this in the mainline repo of rcutils instead of the micro-ROS fork? We keep aligned with the mainline. |
|
I don't know exactly the effects of this check #ifndef __INCLUDE_DIRENT_H on the other OS (freertos and zephyr). For NuttX it is required that the type DIR is not redefined, and the definition is in dirent.h! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file src/filesystem.c is not compatible with NuttX 11, because of the redefinition of the type "DIR"
src/filesystem.c contains a check of __INCLUDE_DIRENT_H now
The redefinition of the type "DIR" causes a failure of the compilation of the libmicroros.a.